Skip to content

Revert #1227 #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2024
Merged

Revert #1227 #1305

merged 1 commit into from
May 16, 2024

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented May 15, 2024

  • Explanation: Revert Merge tests defined in extensions #1227 because it was crashing the compiler during IR generation while we investigate the compiler crash
  • Scope: Test discovery
  • Risk: Low, this is a revert that applied without major conflicts
  • Testing: n/a
  • Issue: rdar://128155050
  • Reviewer: @bnbarham

This reverts commit 6a791fd, reversing changes made to 73cec82.

@ahoppen
Revert "Merge pull request swiftlang#1227 from plemarquand/merge-exte…
ff5db5f 
…nsion-tests"

This reverts commit 6a791fd, reversing
changes made to 73cec82.
@ahoppen ahoppen requested a review from bnbarham May 15, 2024 22:43
@ahoppen ahoppen requested a review from benlangmuir as a code owner May 15, 2024 22:43
@ahoppen
Copy link
Member Author

ahoppen commented May 15, 2024

@swift-ci Please test

@ahoppen ahoppen merged commit 1b0d1e4 into swiftlang:release/6.0 May 16, 2024
3 checks passed
@ahoppen ahoppen deleted the 6.0/revert-test-item-extension-merging branch May 16, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

@benlangmuir benlangmuir Awaiting requested review from benlangmuir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahoppen @bnbarham