Index clang files #1289
Index clang files #1289
Conversation
Fixes swiftlang#1253 rdar://127474135
|
@swift-ci Please test |
| "-MP", | ||
| // Don't writ out compilation databases | ||
| "-MJ", | ||
| // Continue in the presence of errors during indexing |
There was a problem hiding this comment.
Is this the reason? Or is it just that we don't have a decent timestamp to use for the "build session" here? Or does having this enable verification where we wouldn't otherwise?
There was a problem hiding this comment.
Honestly, I don’t know. I was trying to infer it but maybe I was wrong. I just removed the explanation for now.
| result.reserveCapacity(compilerArguments.count) | ||
| var iterator = compilerArguments.makeIterator() | ||
| while let argument = iterator.next() { | ||
| if removeFlags.contains(argument) || argument.starts(with: "-fbuild-session-file=") { |
There was a problem hiding this comment.
Does serailize-diagnostics also allow =? Does -fbuild-session-file allow a separate arg rather than =?
There was a problem hiding this comment.
So, serailize-diagnostics does not allow = and -fbuild-session-file requires a =. But eg. -MT doesn’t require a space. And serialize-diagnostics can be spelled with a single or multiple spaces.
I ended up generalizing the entire command line argument matching in #1314
Fixes #1253
rdar://127474135