Make all non-test modules except for SourceKitLSP build in Swift 6 mode #1276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
ahoppen
commented
May 13, 2024
| @@ -36,36 +36,6 @@ final class ToolchainRegistryTests: XCTestCase { | |||
| await assertTrue(tr.default === tr.toolchain(identifier: "a")) | |||
| } | |||
|
|
|||
| func testDefaultDarwin() async throws { | |||
| let prevPlatform = Platform.current | |||
There was a problem hiding this comment.
These tests are no longer supported because Platform.current isn’t mutable anymore. We should still have coverage fro this because we’re running tests on macOS and Linux.
ahoppen
force-pushed
the
non-test-modules-in-swift-6-mode
branch
2 times, most recently
from
c8f5933 to
d6e93e8
Compare
ahoppen
changed the title
|
swiftlang/swift-package-manager#7553 @swift-ci Please test |
hamishknight
approved these changes
May 13, 2024
|
swiftlang/swift-package-manager#7553 @swift-ci Please test Windows |
This would have caught a race condition in background indexing that was caused by accessing `CheckedIndex` from multiple threads despite it not being thread-safe.
ahoppen
force-pushed
the
non-test-modules-in-swift-6-mode
branch
from
d6e93e8 to
70e373c
Compare
|
swiftlang/swift-package-manager#7553 @swift-ci Please test |
ahoppen
changed the title
|
swiftlang/swift-package-manager#7553 @swift-ci Please test Windows |
ahoppen
changed the title
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on swiftlang/swift-package-manager#7553
This would have caught a race condition in background indexing that was caused by accessing
CheckedIndexfrom multiple threads despite it not being thread-safe.