Address my own review comments to #1179 #1237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
bnbarham
approved these changes
May 8, 2024
| func testAddDocumentationRefactorSingleParameter() throws { | ||
| try assertRefactor( | ||
| """ | ||
| 1️⃣func 2️⃣refactor(syntax: DeclSyntax) { } |
There was a problem hiding this comment.
Is on the label valid? Parameter?
There was a problem hiding this comment.
It doesn't work in the assertRefactor tests because those invoke the refactoring directly from the syntax node. I did add a new code action test case that tests invoking documentation adding from the parameters (because that does the new logic of walking up parents to find the node on which to invoke the refactoring action).
|
Fixed a few more bugs:
|
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
DougGregor
approved these changes
May 8, 2024
Sources/SourceKitLSP/Swift/CodeActions/SyntaxRefactoringCodeActionProvider.swift
Show resolved
Hide resolved
Sources/SourceKitLSP/Swift/CodeActions/SyntaxRefactoringCodeActionProvider.swift
Show resolved
Hide resolved
Addresses a few minor comments and the following major ones: - Add test cases for the syntax refactorings - Don’t report code actions for refactorings that don’t actually modify the source - Instead of just looking at the parent of the token of the selected range, walk up the syntax tree to find the syntax node to refactor. This makes the refactorings available in a lot more locations.
…eclaration’s trivia This meant that if there were two newlines before the declaration, the documentation would be separated to the declaration by one newline and if the declaration was at the start of a line, the declaration would be on the same line as the doc comment, effectively making the documentation part of a comment.
…not on a new line
ahoppen
force-pushed
the
refactoring-review-comments
branch
from
a45a3cf to
f1d6a08
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a few minor comments and the following major ones: