Return fileHandlingCapability.handled for all files that SwiftPMBuildSystem has build settings for
#1232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ildSystem` has build settings for Previously, `SwiftPMBuildSystem` would report `.unhandled` as the file handling capability for `Package.swift`. In single workspace-folder setups, this was not an issue because we would always default to using the build system of the first/only workspace folder, which was the only `SwiftPMBuildSystem` and then returned compiler arguments despite saying that it couldn’t handle `Package.swift`. This, however, breaks if you have a setup with multi workspace folders, where we can’t rely on the first workspace folder being able to provide build settings for the package manifest. To fix this, report `.handled` file handling capability for all files that `SwiftPMBuildSystem` can compute build settings for. Fixes swiftlang#1210 rdar://127351614
|
@swift-ci Please test |
bnbarham
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
SwiftPMBuildSystemwould report.unhandledas the file handling capability forPackage.swift. In single workspace-folder setups, this was not an issue because we would always default to using the build system of the first/only workspace folder, which was the onlySwiftPMBuildSystemand then returned compiler arguments despite saying that it couldn’t handlePackage.swift.This, however, breaks if you have a setup with multi workspace folders, where we can’t rely on the first workspace folder being able to provide build settings for the package manifest.
To fix this, report
.handledfile handling capability for all files thatSwiftPMBuildSystemcan compute build settings for.Fixes #1210
rdar://127351614