Use logic in swift-syntax to translate sequential edits to concurrent edits #1118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… edits Turns out that translation of sequential to concurrent edits is not trivial to implement. Use the logic in swift-syntax that is already well-tested. rdar://123880677
|
@swift-ci Please test |
bnbarham
approved these changes
Mar 6, 2024
| _ = [ | ||
| Node( | ||
| documentation: """ | ||
| 1️⃣A |
There was a problem hiding this comment.
Clever use of emojis :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on swiftlang/swift-syntax#2527
Turns out that translation of sequential to concurrent edits is not trivial to implement. Use the logic in swift-syntax that is already well-tested.
rdar://123880677