[BoundsSafety][NFC] Simplify the interface of BoundsSafetyCheckAssignmentToCountAttrPtrWithIncompletePointeeTy
#9807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delcypher
added
the
clang:bounds-safety
|
@swift-ci test |
|
@swift-ci test llvm |
delcypher
force-pushed
the
dev/dliew/refactor-BoundsSafetyCheckAssignmentToCountAttrPtr
branch
from
b18ab14 to
2e4e871
Compare
rapidsna
approved these changes
Jan 8, 2025
`BoundsSafetyCheckAssignmentToCountAttrPtrWithIncompletePointeeTy` Previously the interface took a std::function<std::string>. The rationale behind this was to prevent callers from always allocating and computing a `std::string`. While trying to upstream this code (rdar://133600117) (llvm#106321) it was pointed out that there might be a simpler way to implement this. This patch instead has callers pass * a `ValueDecl*` pointer. In the cases where this isn't known (currently return values and unnamed parameters) this can be set to nullptr * a boolean flag stating whether or not the `ValueDecl*` should be fully qualified when printed. This avoids needing to pass a `std::function` and also avoids `std::string` unnecessary allocation. rdar://142544708
delcypher
force-pushed
the
dev/dliew/refactor-BoundsSafetyCheckAssignmentToCountAttrPtr
branch
from
2e4e871 to
bb51313
Compare
delcypher
deleted the
dev/dliew/refactor-BoundsSafetyCheckAssignmentToCountAttrPtr
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BoundsSafety][NFC] Simplify the interface of
BoundsSafetyCheckAssignmentToCountAttrPtrWithIncompletePointeeTyPreviously the interface took a std::functionstd::string. The
rationale behind this was to prevent callers from always allocating and
computing a
std::string.While trying to upstream this code (rdar://133600117)
(llvm#106321) it was pointed out
that there might be a simpler way to implement this.
This patch instead has callers pass
ValueDecl*pointer. In the cases where this isn't known (currentlyreturn values and unnamed parameters) this can be set to nullptr
ValueDecl*should be fullyqualified when printed.
This avoids needing to pass a
std::functionand also avoidsstd::stringunnecessary allocation.
rdar://142544708