[lldb] Various changes to get building on next
#8888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JDevlieghere / @adrian-prantl how major is actually implementing the new methods in TypeSystemSwift/DWARFASTParserSwift? |
Adds empty implementations for `GetPtrAuthKey`, `GetPtrAuthDiscriminator`, and `GetPtrAuthAddressDiversity`.
…dDefinitionTypeForDIE`" This reverts commit d1782cc as the upstream change adding it was reverted. Keeping it in history so we can re-apply.
bnbarham
force-pushed
the
get-next-building
branch
from
ee8d64c to
66f6fa9
Compare
| @@ -1349,7 +1349,7 @@ SwiftExpressionParser::ParseAndImport( | |||
| if (enable_bare_slash_regex_literals) { | |||
| lang_opts.enableFeature(swift::Feature::BareSlashRegexLiterals); | |||
| } | |||
| if (uint32_t version = m_expr.Language().version) { | |||
| if (uint32_t version = m_expr.Language().version) | |||
There was a problem hiding this comment.
Heh, yeah. I was going to add the } instead but this matches what was... somewhere (stable/20230725 I assume?)
adrian-prantl
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.