Skip to content

[lldb][Type Completion] XFAIL/un-XFAIL a few more tests on next #8699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2024
Merged

[lldb][Type Completion] XFAIL/un-XFAIL a few more tests on next #8699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lldb/test/API/commands/expression/completion/TestExprCompletion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,7 @@ def test_expr_completion(self):
self.complete_from_to("expr myVec.__m", "expr myVec.__mem")
self.complete_from_to("expr myVec._M", "expr myVec._Mem")

@expectedFailureAll(setting=('plugin.typesystem.clang.experimental-redecl-completion', 'true'))
def test_expr_completion_with_descriptions(self):
self.build()
self.main_source = "main.cpp"
Expand Down
2 changes: 0 additions & 2 deletions lldb/test/API/functionalities/limit-debug-info/TestLimitDebugInfo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,6 @@ def test_one_and_two_debug(self):

self._check_incomplete_frame_variable_output()

@expectedFailureAll(setting=('plugin.typesystem.clang.experimental-redecl-completion', 'true'))
@skipIf(bugnumber="pr46284", debug_info="gmodules")
@skipIfWindows # Clang emits type info even with -flimit-debug-info
# Requires DW_CC_pass_by_* attributes from Clang 7 to correctly call
Expand Down Expand Up @@ -292,7 +291,6 @@ def test_two_debug(self):

self._check_incomplete_frame_variable_output()

@expectedFailureAll(setting=('plugin.typesystem.clang.experimental-redecl-completion', 'true'))
@skipIf(bugnumber="pr46284", debug_info="gmodules")
@skipIfWindows # Clang emits type info even with -flimit-debug-info
# Requires DW_CC_pass_by_* attributes from Clang 7 to correctly call
Expand Down
19 changes: 17 additions & 2 deletions lldb/test/API/functionalities/type_lookup/TestTypeLookup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,24 @@ def test_type_lookup(self):
"type lookup PleaseDontBeARealTypeThatExists",
substrs=["no type was found matching 'PleaseDontBeARealTypeThatExists'"],
)
self.expect("type lookup MyCPPClass", substrs=["setF", "float getF"])
self.expect("type lookup MyClass", substrs=["setF", "float getF"])
self.expect(
"type lookup MyObjCClass",
substrs=["@interface MyObjCClass", "int x", "int y"],
)

@expectedFailureAll(setting=('plugin.typesystem.clang.experimental-redecl-completion', 'true'))
@skipUnlessDarwin
@skipIf(archs=["i386"])
@skipIfDarwinEmbedded # swift crash inspecting swift stdlib with little other swift loaded <rdar://problem/55079456>
def test_type_lookup_cpp_methods(self):
"""Test type lookup command."""
self.build()
self.runCmd("file " + self.getBuildArtifact("a.out"), CURRENT_EXECUTABLE_SET)

lldbutil.run_break_set_by_file_and_line(
self, "main.mm", self.line, num_expected_locations=1, loc_exact=True
)

self.runCmd("run", RUN_SUCCEEDED)
self.expect("type lookup MyCPPClass", substrs=["setF", "float getF"])
self.expect("type lookup MyClass", substrs=["setF", "float getF"])