Resolve some doccomment and Swift interop warnings #8308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
force-pushed
the
resolve-warnings
branch
from
63b8020 to
43af5ed
Compare
Swift C++ interop has a bug where certain operator declarations cannot be imported successfully due to percieved circular references in the declarations. Since these declarations are already dropped by the ClangImporter, it's helpful to hide the declarations entirely from Swift to avoid spurious diagnostics that cannot be addressed. See swiftlang/swift#71032 for a similar workaround in the Swift compiler implementation.
tshortli
force-pushed
the
resolve-warnings
branch
from
43af5ed to
2ef7ef1
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#ifndef __swift__guards. Swift C++ interop has a bug where certain operator declarations cannot be imported successfully due to percieved circular references in the declarations. Since these declarations are already dropped by the ClangImporter, it's helpful to hide the declarations entirely from Swift to avoid spurious diagnostics that cannot be addressed. See NFC: Work around 'cycle detected while resolving' warning swift#71032 for a similar workaround in the Swift compiler implementation.