🍒 [Coro][WebAssembly] Add tail-call check for async lowering #8173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a verifier error when async lowering is used for WebAssembly target without tail-call feature. This missing check was revealed by b1ac052, which removed inlining of the musttail'ed call and it started leaving the invalid call at the verification stage. Additionally, `TTI::supportsTailCallFor` did not respect the concrete TTI's `supportsTailCalls` implementation, so it always returned true even though `supportsTailCalls` returned false, so this patch also fixes the wrong CRTP base class implementation.
kateinoigakukun
force-pushed
the
yt/cherry-pick-wasm-coro-fix
branch
from
96c228e to
625a0c9
Compare
|
@swift-ci test |
|
@swift-ci test macOS platform |
|
@swift-ci Please test macOS platform |
MaxDesiatov
approved these changes
Feb 20, 2024
|
This will repair the compiler crash in WebAssembly CI https://ci-external.swift.org/job/oss-swift-RA-linux-ubuntu-20.04-webassembly/1963/console |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick llvm#81481
This patch fixes a verifier error when async lowering is used for WebAssembly target without tail-call feature. This missing check was revealed by b1ac052, which removed inlining of the musttail'ed call and it started leaving the invalid call at the verification stage. Additionally,
TTI::supportsTailCallFordid not respect the concrete TTI'ssupportsTailCallsimplementation, so it always returned true even thoughsupportsTailCallsreturned false, so this patch also fixes the wrong CRTP base class implementation.