Skip to content

[5.9][Swift/Macros] Update for plugin search options change #6999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2023
Merged

[5.9][Swift/Macros] Update for plugin search options change #6999

merged 1 commit into from
Jun 16, 2023

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jun 15, 2023 •
edited
Loading

Cherry-pick #6998 into swift/release/5.9

Companion of swiftlang/swift#66678

  • Explanation: The compiler currently orders compiler plugin lookup by kind. Instead, we should respect the exact ordering of the various arguments (-external-plugin-path, -plugin-path, etc.) on the command line when performing lookups.
  • Scope: Macro plugin loading
  • Risk: Low-Mid, Since this changes the plugin searching mechanism, it might changes the current behavior depending on how clients specify the arguments. But we expect almost none existing clients will be affected.
  • Testing: Regression tests updated
  • Issue: rdar://110819182

@rintaro
[Swift/Macros] Update for plugin search options change
3dbcb08 
rdar://110819182
(cherry picked from commit 3a58867)
@rintaro rintaro mentioned this pull request Jun 15, 2023
Merged
@rintaro
Copy link
Member Author

rintaro commented Jun 15, 2023

swiftlang/swift#66678
@swift-ci Please test

@DougGregor DougGregor merged commit cc42a0d into swiftlang:swift/release/5.9 Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @DougGregor