Skip to content

WIP: [lldb][test] Re-enable TestDataFormatterLibcxxRangesRefView.py #6893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Michael137
Copy link

@Michael137 Michael137 commented May 19, 2023

@Michael137
Copy link
Author

Please test with following PR:
swiftlang/swift#66018

@swift-ci Please test macOS platform

@Michael137
Copy link
Author

Please test with following PR:
swiftlang/swift#66018

@swift-ci test

@Michael137
Copy link
Author

Please test with following PR:
swiftlang/swift#66026

@swift-ci test

@Michael137
Copy link
Author

trying against 5.9 since main isn't buildable right now

@Michael137
Copy link
Author

Please test with following PR:
swiftlang/swift#66026
#6899

@swift-ci test

…builds

Standalone builds currently do not set the `LLDB_HAS_LIBCXX`,
`LIBCXX_LIBRARY_DIR`, `LIBCXX_GENERATED_INCLUDE_DIR`.
These are necessary for API tests with `USE_LIBCPP` to run against
a custom built libcxx. Thus on all buildbots using standalone builds
(most notably the public swift-ci), the API tests always run against
the libcxx headers in the system SDK.

This patch introduces a new cmake variable `LLDB_TEST_LIBCXX_ROOT_DIR`
that allows us to point the tests in standalone builds to a custom
libcxx directory.

Since the user can control the libcxx location we can hard error if
no such custom libcxx build exists.

Differential Revision: https://reviews.llvm.org/D150954

(cherry picked from commit 2901ce3ac24799dacda21be3903d6d8294b70ea0)
@Michael137
Copy link
Author

Please test with following PR:
swiftlang/swift#66026

@swift-ci test

@Michael137
Copy link
Author

Please test with following PR:
swiftlang/swift#66026

@swift-ci test Windows platform

@Michael137 Michael137 closed this May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant