[lldb] Fix mangled name being overwritten on type with DW_AT_specific… #11227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation The order of the attributes wasn't deterministic, and it just happened that the DW_AT_linkage_name of the specifier type used to always come last. Now the algorithm for parsing attributes has changed and made deterministic, and the current algorithm will parse the attributes of the specifier TAG first, and specified last. Make sure to not overwrite the mangled name of a specified type. rdar://158634690
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ation
The order of the attributes wasn't deterministic, and it just happened that the DW_AT_linkage_name of the specifier type used to always come last. Now the algorithm for parsing attributes has changed and made deterministic, and the current algorithm will parse the attributes of the specifier TAG first, and specified last.
Make sure to not overwrite the mangled name of a specified type.
rdar://158634690