[lldb] remove unittest2 from tests #11084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have not tested this at desk yet, I want to make sure this does not break any tests on any platforms. cc @felipepiovezan since you removed the |
|
@swift-ci please test |
charles-zablit
requested review from
Michael137,
adrian-prantl and
felipepiovezan
|
@swift-ci please test windows |
felipepiovezan
approved these changes
Jul 30, 2025
|
@swift-ci please clean test Windows platform |
|
@swift-ci please test windows |
1 similar comment
|
@swift-ci please test windows |
|
@swift-ci please test |
This was referenced Aug 4, 2025
adrian-prantl
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From unittest2's Readme: unittest2 is a backport of the new features added to the unittest testing framework in Python 2.7 and onwards. It is tested to run on Python 2.6, 2.7, 3.2, 3.3, 3.4 and pypy.
Since, we use Python
3.9.10to test LLDB, there is no need forunittest2anymore.This patch is a follow up to d26912d, which removes the use of
unittest2in all of LLDB testing.