🍒 [lldb] Fix building with GCC without asserts (llvm@fcead25) #10732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This case was missed in 03604a7. Cherry-picked from llvm/llvm-project@fcead25
|
@swift-ci please test |
JDevlieghere
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream LLVM landed a fix for toolchain builds without asserts, which was missed in 03604a7. This was cherry-picked into the swiftlang fork, but not in the 6.2 branch. As it is, the 6.2 branch does not build without asserts enabled.
This only affects the NoAsserts toolchain build.
N/A
Original LLVM commit llvm/llvm-project@fcead25
Cherry-picked from 🍒 [lldb] Fix building with GCC without asserts (llvm@fcead25) #10453
Very low. Should be a no-op for most users.
Same error on our toolchain build as the one witnessed on main a month ago.
@compnerd