Pass platform name in SwiftCore link #10725
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The platform name was hard-coded to `linux`. The target name when
building for FreeBSD is `swiftCore-freebsd-${arch}` resulting in a build
failure due to the missing swiftCore-linux-${arch} target.
|
CC @finagolfin and @3405691582 |
|
@swift-ci please test |
|
Sounds good, I haven't tried building this forked lldb for Android yet, so haven't hit this. |
|
Seems reasonable, but I also haven't built lldb this way (we get a lot of LLVM, including lldb, through the platform). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The platform name was hard-coded to
linux. The target name when building for FreeBSD isswiftCore-freebsd-${arch}resulting in a build failure due to the missing swiftCore-linux-${arch} target.Looking at the android bots, it looks like the swiftCore target name there is
swiftCore-android-${arch}, so the hard-coded value is incorrect when building lldb to run on Android too.