Use full module triple in swiftmodule install #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates the CMake build to install the IndexStoreDB module with the full triple. This allows us to query the compiler for the appropriate module name instead of maintaining the long list of host architectures, making the build more resilient to changes in the future.
etcwilde
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
|
@swift-ci please test |
compnerd
approved these changes
May 23, 2025
bnbarham
approved these changes
May 28, 2025
|
Could you run a Windows toolchain build (might have to cross-PR from Swift) 🙏? |
|
We don't distribute IndexStoreDB as a re-usable module, so the swiftmodules aren't packaged. This is a pure build component for Windows. |
Yeah I know, I just wanted to make sure the build still passed (for dependencies of IndexStoreDB) and the Windows toolchain is the only place this would be used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the CMake build to install the IndexStoreDB module with the full triple. This allows us to query the compiler for the appropriate module name instead of maintaining the long list of host architectures, making the build more resilient to changes in the future.