Closed
Conversation
| default: "" | ||
| musl_pre_build_command: | ||
| type: string | ||
| description: "Linux command to execute before building the Swift package" |
Contributor
There was a problem hiding this comment.
I think the description here just needs updated, as it's the same as the linux_pre_build_command
| - name: Check out code | ||
| uses: actions/checkout@v4 | ||
| - name: Install SDK | ||
| run: swift sdk install https://download.swift.org/swift-6.0.1-release/static-sdk/swift-6.0.1-RELEASE/swift-6.0.1-RELEASE_static-linux-0.0.1.artifactbundle.tar.gz --checksum d4f46ba40e11e697387468e18987ee622908bc350310d8af54eb5e17c2ff5481 |
Contributor
There was a problem hiding this comment.
do we want a hardcoded checksum/artifact url hardcoded here? Or should they be inputs
sebsto
reviewed
Oct 30, 2024
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| container: swift:6.0-noble |
Contributor
There was a problem hiding this comment.
The version here must be exactly the same as the SDK below. As of today (30/10) swift:6.0-noble vends Swift 6.0.2 which is not working with the SDK 6.0.1.
I suggest to pass both the Swift version number and the checksum as parameters
Member
Author
|
The NIO team are working on something that actually works - apple/swift-nio#3019 |
Member
|
Supported add it recently - #142 |
Member
|
Please re-open the PR if it does not solve the problem you were facing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resloves #34
Need to decide how to handle different versions and probably improve the workflow for installing the correct static SDK but opening as is for now for discussion