Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/swift_package_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -682,7 +682,7 @@ jobs:
uses: actions/setup-python@v6
with:
python-version: "3.10"
architecture: "x86"
architecture: "x64"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"If the input is not specified, the architecture defaults to the host OS architecture."

Can you just remove the architecture line @matthewbastien? As is, this will install the wrong architecture on Windows on ARM builds, which were recently added in #190

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, no arm64 binary exists for Python 3.10 which is why I pinned it to x64.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, I guess we'll have to wait until Swift upgrades to Python 3.11 to fix this.

- name: Install Visual Studio Build Tools
if: ${{ !inputs.enable_windows_docker }}
run: . ${{ steps.script_path.outputs.root }}/.github/workflows/scripts/windows/install-vsb.ps1
Expand Down