Add Embedded Swift for Wasm support to install-and-build-with-sdk.sh#145
Add Embedded Swift for Wasm support to install-and-build-with-sdk.sh#145shahmishal merged 8 commits intoswiftlang:mainfrom
install-and-build-with-sdk.sh#145Conversation
* Add workflows for Linux static SDK and Wasm SDK builds * Update URLs and remove extra PR testing to prepare for merge
jrflat
left a comment
There was a problem hiding this comment.
Thanks for fixing the SDK terminology and adding embedded support! Left some comments on logs that could also be updated from just "static SDK" but looks good.
Just to clarify, the _wasm-embedded SDK is included in the _wasm.artifactbundle.tar.gz that's installed, right? Also, do we want to add a job that tests the embedded build in swift_package_test.yml and pull_request.yml?
Thanks!
Yes.
Those will be changed in follow up PRs, as I don't see a way for a workflow change PR to refer to a script using absolute URL changed in the same PR. Before merging we need it to refer to |
Also cleaned up incorrect "SDK" naming: we're using Swift SDKs and not plain Clang or Xcode SDKs in these workflows.
Additionally "static SDK" is very non-specific, Swift SDKs for Wasm are also static, as we currently don't support dynamic linking on that platform. We should fully specify it as "Static Linux", same as in https://www.swift.org/documentation/articles/static-linux-getting-started.html