Skip to content

Bump minimum Swift version to 5.7 #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 5, 2023
Merged

Bump minimum Swift version to 5.7 #160

merged 2 commits into from
Oct 5, 2023

Conversation

rnro
Copy link
Contributor

@rnro rnro commented Oct 4, 2023

Motivation:

Now that Swift 5.9 is GM we should update the supported versions and remove 5.6

Modifications:

  • Update Package.swift
  • Delete the <5.7 docker compose files and make a 5.10 one
  • Update the 5.9 docker file to stop using nightlies

Result:

Remove support for Swift 5.6, add 5.10

@rnro
Bump minimum Swift version to 5.7
4c92a11 
Motivation:

Now that Swift 5.9 is GM we should update the supported versions and
remove 5.6

Modifications:

* Update `Package.swift`
* Delete the <5.7 docker compose files and make a 5.10 one
* Update the 5.9 docker file to stop using nightlies

Result:

Remove support for Swift 5.6, add 5.10
@FranzBusch
Copy link
Contributor

@swift-server-bot add to allowlist

ktoso
ktoso approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rnro
Copy link
Contributor Author

rnro commented Oct 4, 2023

@swift-server-bot test this please

1 similar comment
@FranzBusch
Copy link
Contributor

@swift-server-bot test this please

@rnro
Copy link
Contributor Author

rnro commented Oct 4, 2023

@yim-lee Could you please update the CI here too?

@yim-lee
Copy link
Collaborator

yim-lee commented Oct 4, 2023

CI updated. @swift-server-bot test this please

@FranzBusch
Copy link
Contributor

@yim-lee any idea why we are continuing to time out on the 5.7 CI? This wasn't the case a few days back and it seems to be stuck during linking. Is this an issue with the node?

@yim-lee
Copy link
Collaborator

yim-lee commented Oct 4, 2023

@swift-server-bot test this please

@yim-lee
Copy link
Collaborator

yim-lee commented Oct 4, 2023

Hmm, the 5.7 job timed out on three different nodes, then it just ran on yet another node and finished under 40s. I ran CI cleanup job before which might have helped? Not sure.

@swift-server-bot test this please

@yim-lee
Copy link
Collaborator

yim-lee commented Oct 4, 2023

@swift-server-bot test this please

@yim-lee
Remove '--enable-test-discovery'
ddee4ad 
To see if it's causing CI build getting stuck
@yim-lee
Copy link
Collaborator

yim-lee commented Oct 4, 2023

@swift-server-bot test this please

@yim-lee
Copy link
Collaborator

yim-lee commented Oct 4, 2023 •
edited
Loading

With ddee4ad, the 5.7 job has passed two times on one of the nodes that it failed on before. Maybe it's that?

It went on agent 4 on the third run and it's getting stuck again: https://ci.swiftserver.group/job/swift-service-lifecycle-swift57-prb/110/console

@yim-lee
Copy link
Collaborator

yim-lee commented Oct 4, 2023

@swift-server-bot test this please

@yim-lee
Copy link
Collaborator

yim-lee commented Oct 4, 2023

A couple of test failures in 5.9: https://ci.swiftserver.group/job/swift-service-lifecycle-swift59-prb/62/console

@yim-lee
Copy link
Collaborator

yim-lee commented Oct 4, 2023

@swift-server-bot test this please

3 similar comments
@yim-lee
Copy link
Collaborator

yim-lee commented Oct 4, 2023

@swift-server-bot test this please

@yim-lee
Copy link
Collaborator

yim-lee commented Oct 4, 2023

@swift-server-bot test this please

@yim-lee
Copy link
Collaborator

yim-lee commented Oct 4, 2023

@swift-server-bot test this please

@yim-lee
Copy link
Collaborator

yim-lee commented Oct 4, 2023 •
edited
Loading

I don't know what causes 5.7 build to stuck sometimes.

Some observations:

  • It seems to always build successfully right after I touch the job config (agents 6 and 5).
  • So far the job always fails on agent 4 and subsequent runs fail, even on different agent (agent 5).
  • It might continue to run fine after a successful run if subsequence runs stayed on the same agent (2 consecutive successful runs on agent 5).
  • I don't think it's agent specific because 5.10 ran fine on agent 4.

Filed radar to investigate: rdar://116487361

@FranzBusch
Copy link
Contributor

Thanks for investigating this a bit @yim-lee. Let's merge this and keep an eye on it.

@FranzBusch FranzBusch merged commit 4d11d98 into swift-server:main Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktoso ktoso ktoso approved these changes

@FranzBusch FranzBusch FranzBusch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rnro @FranzBusch @yim-lee @ktoso