Skip to content

[core] Swift Service Lifecycle (WIP - do not merge) #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed

[core] Swift Service Lifecycle (WIP - do not merge) #456

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
c4c71cc
initial commit
sebsto Jan 5, 2025
accb29b
make the logger accessible
sebsto Jan 6, 2025
9b0a617
Merge branch 'main' into sebsto/servicelifecycle
sebsto Jan 8, 2025
76677b0
Merge branch 'sebsto/servicelifecycle' of github.com:sebsto/swift-aws…
sebsto Jan 9, 2025
ba85f5b
add example
sebsto Jan 9, 2025
cc89338
move service conformance to a separate class
sebsto Jan 9, 2025
01a4443
move AWSLambdaRuntimeService to a separate module to avoid penalty fo…
sebsto Jan 9, 2025
30bfa4f
move the convenience initializers in a separate file
sebsto Jan 9, 2025
7db7775
wip to add support for service lifecycle
sebsto Jan 11, 2025
24dc426
fix logger label + add doc header
sebsto Jan 11, 2025
739d237
replace NIOConcurrencyHelpers with Synchronization.Mutex
sebsto Jan 11, 2025
d1247fa
add link to postgres-nio issue
sebsto Jan 12, 2025
7d5257c
Add cancellation handling for nextInvocation()
adam-fowler Jan 12, 2025
c271eaf
Merge remote-tracking branch 'upstream/cancel-next-invocation' into s…
sebsto Jan 12, 2025
d865a0f
rename runtime cancellation to graceful shutdown
sebsto Jan 12, 2025
b2e59ff
Merge branch 'main' into sebsto/servicelifecycle
sebsto Jan 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make the logger accessible
  • Loading branch information
@sebsto
sebsto committed Jan 6, 2025
commit accb29bda746b40ed124ce7554821721d4a33de3
4 changes: 3 additions & 1 deletion Sources/AWSLambdaRuntimeCore/LambdaRuntime.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ import Foundation
public final class LambdaRuntime<Handler>: Service, @unchecked Sendable where Handler: StreamingLambdaHandler {
// TODO: We want to change this to Mutex as soon as this doesn't crash the Swift compiler on Linux anymore
let handlerMutex: NIOLockedValueBox<Handler?>
let logger: Logger

// logger is accessible from the outside, but only mutable from the inside
public private(set) var logger: Logger
let eventLoop: EventLoop

public init(
Expand Down