Skip to content

Mark deprecated FunctionURLResponse init as @_disfavoredOverload #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025

Conversation

natanrolnik
Copy link
Contributor

@natanrolnik natanrolnik commented Aug 6, 2025

In a previous PR (#91), a new init with a different parameters order was added, marking the previous one was deprecated. The problem is that the compiler doesn't know which one to choose when omitting the final parameters.

This PR fixes it by marking the deprecated init with @_disfavoredOverload.

@sebsto sebsto self-requested a review August 7, 2025 05:03
@sebsto sebsto self-assigned this Aug 7, 2025
@sebsto sebsto added the 🔨 semver/patch No public API change. label Aug 7, 2025
Copy link
Contributor

@sebsto sebsto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for having catch this.

@sebsto sebsto merged commit 5aa3a63 into swift-server:main Aug 7, 2025
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants