workaround Foundation.URL behavior changes #777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnro
force-pushed
the
foundation_url_behavior_changes
branch
3 times, most recently
from
6b61458 to
8cf9960
Compare
Lukasa
reviewed
Oct 3, 2024
|
|
||
| switch scheme { | ||
| case .http, .https: | ||
| #if os(Linux) && compiler(>=6.0) |
Collaborator
There was a problem hiding this comment.
This is the wrong check: it's if !canImport(Darwin)
| switch scheme { | ||
| case .http, .https: | ||
| #if os(Linux) && compiler(>=6.0) | ||
| guard var urlHost = url.host, !urlHost.isEmpty else { |
Collaborator
There was a problem hiding this comment.
Suggested change
| guard var urlHost = url.host, !urlHost.isEmpty else { | |
| guard let urlHost = url.host, !urlHost.isEmpty else { |
| let request3 = try Request(url: "unix:///tmp/file") | ||
| XCTAssertNil(request3.url.host) | ||
| XCTAssertEqual(request3.host, "") | ||
| #if os(Linux) && compiler(>=6.0) |
`Foundation.URL` has various behavior changes in Swift 6 to better match RFC 3986 which impact AHC. In particular it now no longer strips the square brackets in IPv6 hosts which are not tolerated by `inet_pton` so these must be manually stripped.
rnro
force-pushed
the
foundation_url_behavior_changes
branch
from
8cf9960 to
ee5009a
Compare
Lukasa
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Foundation.URLhas various behavior changes in Swift 6 to better match RFC 3986 which impact AHC.In particular it now no longer strips the square brackets in IPv6 hosts which are not tolerated by
inet_ptonso these must be manually stripped.swiftlang/swift-foundation#957 - Initializing a URL from an IPv6 address in Swift 6 on Linux now does not strip enclosing square-brackets.
swiftlang/swift-foundation#958 - Initializing a URL from a unix file path in Swift 6 on Linux now returns a non-nil value (an empty
String).swiftlang/swift-foundation#962 - Initializing a URL from an empty string in Swift 6 on Linux now returns a non-nil URL value.