-
Notifications
You must be signed in to change notification settings - Fork 125
Fix crash for large HTTP request headers #661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dnadoba
merged 21 commits into
swift-server:main
from
dnadoba:dn-fix-large-header-request
Feb 10, 2023
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
0aecc2b
Reproducer
dnadoba c43bccc
Refactor test case
dnadoba fb64416
Refactor tests
dnadoba cb026ca
Remove debugging artefacts
dnadoba a7f64d4
Fix typo
dnadoba 3f8f55f
Fix formatting
dnadoba efa86b5
Remove `promise?.succeed(())`
dnadoba 38b3bf0
Add test for HTTP2 request with large header
dnadoba 8ad3d8a
Remove logging
dnadoba c9a2814
Fix crash for large HTTP request headers
dnadoba 5fb70dc
Formatting and linux tests
dnadoba 183f75e
Formatting and linux tests
dnadoba 9603f98
Merge branch 'main' into dn-large-header-tests-http2
dnadoba 7d96a89
Generate linux tests
dnadoba 1ddafda
Use previous default max concurrent streams value of 10
dnadoba 55849b5
Merge branch 'dn-large-header-tests-http2' into dn-fix-large-header-r…
dnadoba 31cc312
Merge branch 'main' into dn-fix-large-header-request
dnadoba 18f6505
Fix crash if request is canceled after request header is send
dnadoba 247928a
Merge branch 'main' into dn-fix-large-header-request
Lukasa 7fcecdf
generate linux tests and run swift format
dnadoba 43ebc95
Merge branch 'main' into dn-fix-large-header-request
dnadoba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this force-unwrap safe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment