Skip to content

Raise minimum supported Swift version from 5.4 to 5.5 #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 28, 2022

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Sep 28, 2022

Motivation:

SwiftNIO periodically drops support for older Swift versions. Now that 5.7 has been released, 5.4 will be dropped.

Modifications:

  • Remove 5.4 specific Package.swift and docker-compose
  • Update the 5.7 docker-compose to use the released 5.7 and move from focal (2004) to jammy (2204)
  • Update tools version in Package@swift-5.5.swift to 5.5 (from 5.4)
  • Add supported versions section to README

Results:

Minimum Swift version is 5.5

Motivation:

SwiftNIO periodically drops support for older Swift versions. Now that
5.7 has been released, 5.4 will be dropped.

Modifications:

- Remove 5.4 specific Package.swift and docker-compose
- Update the 5.7 docker-compose to use the released 5.7 and move from
  focal (2004) to jammy (2204)
- Update tools version in Package@swift-5.5.swift to 5.5 (from 5.4)
- Add supported versions section to README

Results:

Minimum Swift version is 5.5
@swift-server-bot
Copy link

Can one of the admins verify this patch?

6 similar comments
@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@glbrntt glbrntt requested a review from fabianfett September 28, 2022 08:15
@glbrntt glbrntt added the 🆕 semver/minor Adds new public API. label Sep 28, 2022
@Lukasa
Copy link
Collaborator

Lukasa commented Sep 28, 2022

@swift-server-bot add to allowlist

Copy link
Collaborator

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a sneaking suspicion that the 5.5 build is going to fail.

@yim-lee
Copy link
Contributor

yim-lee commented Sep 28, 2022

CI updated. @swift-server-bot test this please

@glbrntt glbrntt merged commit b57bcb9 into swift-server:main Sep 28, 2022
@glbrntt glbrntt deleted the gb-add-5.7 branch September 28, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants