Skip to content

add a future-returning shutdown method #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2022
Merged

add a future-returning shutdown method #626

merged 1 commit into from
Sep 7, 2022

Conversation

weissi
Copy link
Contributor

@weissi weissi commented Sep 6, 2022

No description provided.

@weissi weissi force-pushed the jw-future-shutdown branch from 6fc4771 to 4d2e6a0 Compare September 6, 2022 19:29
Lukasa
Lukasa requested changes Sep 7, 2022
View reviewed changes
Copy link
Collaborator

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I'm happy with this patch, but can we place the code in HTTPClient.swift instead of in the AsyncAwait directory?

@weissi weissi force-pushed the jw-future-shutdown branch from 4d2e6a0 to bf27a7a Compare September 7, 2022 12:58
@weissi weissi force-pushed the jw-future-shutdown branch from bf27a7a to 52689d2 Compare September 7, 2022 12:59
@weissi weissi requested a review from Lukasa September 7, 2022 12:59
@weissi
Copy link
Contributor Author

weissi commented Sep 7, 2022

whoops, didn't see that. good catch, fixed

@Lukasa Lukasa added the 🆕 semver/minor Adds new public API. label Sep 7, 2022
@Lukasa Lukasa enabled auto-merge (squash) September 7, 2022 13:01
@Lukasa Lukasa merged commit 7f998f5 into swift-server:main Sep 7, 2022
@weissi weissi deleted the jw-future-shutdown branch September 7, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weissi @Lukasa