Allow HTTPClientRequest
to be executed multiple times if body
is an AsyncSequence
#620
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
AsyncSequence.makeAsyncIterator()
was only called once during the creation ofHTTPClientRequest.Body
and would have been shared if anHTTPClientRequest
is executed a second time.Modification
AsyncSequence.makeAsyncIterator()
for each invocation ofHTTPClient.execute
Result
We no longer share the
AsyncIterator
between different request executions. If the givenAsyncSequence
actually supports multiple iterators, and therefore can be correctly used by multiple request executions, depends on the concrete type though.