Skip to content

Tollerate more data after request body is cancelled #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 18, 2022

Conversation

dnadoba
Copy link
Collaborator

@dnadoba dnadoba commented Aug 17, 2022

We might still get pending buffers if the user has canceled the request because they might already be enqueued to be delivered. We therefore need to tolerate buffers after we are in the error state.

Fixes #612

@dnadoba dnadoba added the 🔨 semver/patch No public API change. label Aug 17, 2022
@Lukasa Lukasa merged commit 0469acb into swift-server:main Aug 18, 2022
@dnadoba dnadoba deleted the dn-async-await-cancelation branch August 18, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AsyncHTTPClient Transaction StateMachine Fatal Error with large Response Bodies
2 participants