Add logging to the new HTTPConnectionPool #428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
commented
Sep 15, 2021
Comment on lines
-134
to
-139
| didSet { | ||
| self.logger.trace("Connection Pool State changed", metadata: [ | ||
| "key": "\(self.key)", | ||
| "state": "\(self._state)", | ||
| ]) | ||
| } |
There was a problem hiding this comment.
Removed, since it produces way too many logs. We should solely focus on recording the events so that we can replay the finite state machine if needed.
fabianfett
commented
Sep 15, 2021
Comment on lines
-147
to
-149
| if let idleReadTimeout = self.request?.idleReadTimeout { | ||
| self.idleReadTimeoutStateMachine = .init(timeAmount: idleReadTimeout) | ||
| } |
There was a problem hiding this comment.
This could be removed, since it is already included in the request setter (l. 143). We have tests that ensure that idle read timeouts work as expected. Those continue to succeed.
Lukasa
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To debug the new
HTTPConnectionPoolandConnections, it would be great to get a rather complete event story.Changes
Connection.KeyResult
A better debuggable AHC client.