Skip to content

Add FileDownloadDelegate for simple file downloads #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Sep 10, 2020
Merged

Add FileDownloadDelegate for simple file downloads #275

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
9e7b767
Add FileDownloadDelegate for simple file downloads
MaxDesiatov Jun 24, 2020
dce7a89
Add testFileDownload to the allTests array
MaxDesiatov Jun 24, 2020
cc223ef
Fix formatting
MaxDesiatov Jun 24, 2020
e8b019e
Fix compatibility with Swift 5.0
MaxDesiatov Jun 24, 2020
68559ba
Add doc comments, update README.md
MaxDesiatov Jun 24, 2020
34ae01c
Refine FileDownloadDelegate description in README
MaxDesiatov Jun 24, 2020
d7c6bb4
Bump NIO version, remove weak self, cleanup test
MaxDesiatov Sep 3, 2020
e10c6f0
Fix formatting issues in a doc comment
MaxDesiatov Sep 3, 2020
b091019
Create separate Progress struct, async open file
MaxDesiatov Sep 7, 2020
43b71ca
Create an ad-hoc EventLoopGroup for opening a file
MaxDesiatov Sep 7, 2020
f75fb8c
Move file opening code to `didReceiveBodyPart`
MaxDesiatov Sep 7, 2020
912ca16
Fix linter error in FileDownloadDelegate.swift
MaxDesiatov Sep 7, 2020
bac8670
Fix wrong future assignment in FileDownloadDelegate
MaxDesiatov Sep 7, 2020
e89a351
Fix Swift 5.0 return statement compatibility
MaxDesiatov Sep 7, 2020
971ef86
Fix linter warning
MaxDesiatov Sep 7, 2020
a22ed50
Fix Swift 5.0 return statement compatibility
MaxDesiatov Sep 7, 2020
f5b6cdd
Remove redundant `write` function
MaxDesiatov Sep 8, 2020
7b25a4f
Add negative test case and separate testing endpoint
MaxDesiatov Sep 8, 2020
6b041b5
Add missing testFileDownloadError to the manifest
MaxDesiatov Sep 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix formatting issues in a doc comment
  • Loading branch information
@MaxDesiatov
MaxDesiatov committed Sep 8, 2020
commit e10c6f0ac077daade79bcdc2cacd68a7d75956cc
4 changes: 2 additions & 2 deletions Sources/AsyncHTTPClient/FileDownloadDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ public final class FileDownloadDelegate: HTTPClientResponseDelegate {
/// - pool: A thread pool to use for asynchronous file I/O.
/// - reportHeaders: A closure called when the response headers are available.
/// - reportProgress: A closure called when a body chunk has been downloaded, with
/// the total byte count and download byte count passed to it as arguments. The callbacks
/// will be invoked in the same threading context that the delegate itself is invoked,
/// the total byte count and download byte count passed to it as arguments. The callbacks
/// will be invoked in the same threading context that the delegate itself is invoked,
/// as controlled by `EventLoopPreference`.
public init(
path: String,
Expand Down