Skip to content

draft for streaming el fixes #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 20, 2020
Merged

draft for streaming el fixes #215

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
05f3409
draft for streaming el fixes
artemredkin May 18, 2020
8766d49
fix compilation
artemredkin May 18, 2020
c28d434
Merge branch 'master' into fix_streaming_el
artemredkin May 20, 2020
b4bb076
remove hack
artemredkin May 20, 2020
b4abced
fix formatting
artemredkin May 20, 2020
075c768
split tests
artemredkin May 20, 2020
1cd8dd0
fix test server shutdown
artemredkin May 20, 2020
435c03e
fix linuxtests
artemredkin May 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test server shutdown
  • Loading branch information
@artemredkin
artemredkin committed May 20, 2020
commit 1cd8dd0df341e6217d180ede8e43edb0526d1e73
5 changes: 5 additions & 0 deletions Tests/AsyncHTTPClientTests/HTTPClientTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1705,6 +1705,7 @@ class HTTPClientTests: XCTestCase {
private let bodyPromises: [EventLoopPromise<ByteBuffer>]
private let endPromise: EventLoopPromise<Void>
private var bodyPartsSeenSoFar = 0
private var atEnd = false

init(headPromise: EventLoopPromise<HTTPRequestHead>,
bodyPromises: [EventLoopPromise<ByteBuffer>],
Expand All @@ -1727,10 +1728,14 @@ class HTTPClientTests: XCTestCase {
context.write(self.wrapOutboundOut(.head(.init(version: .init(major: 1, minor: 1), status: .ok))),
promise: nil)
context.writeAndFlush(self.wrapOutboundOut(.end(nil)), promise: self.endPromise)
self.atEnd = true
}
}

func handlerRemoved(context: ChannelHandlerContext) {
guard !self.atEnd else {
return
}
struct NotFulfilledError: Error {}

self.headPromise.fail(NotFulfilledError())
Expand Down