List of core application logic implemented only on GUI side

[oktal3700]

A lot of the core application logic is implemented only in the GUI code, violating MVC design principles. This makes it impossible to rewrite the GUI without also rewriting lots of core logic. Such logic must be moved to the core side, as a prerequisite to rewriting the GUI.

This issue is a place to collect a list of all parts of the application logic that fall into this category:

• Auto-logoff timer (CLoginComponent triggers an uncommanded disconnect under certain conditions)

[ltoenning]

• Loading models from disk:

  pilotclient/src/gui/components/dbownmodelscomponent.cpp

  Lines 749 to 788 in 940b728

  	if (!m_modelLoader) { return; }
  	// here m_modelLoader is still the "current" loader
  	if (m_modelLoader->isLoadingInProgress())
  	{
  	if (m_modelLoader->supportsSimulator(simulator))
  	{
  	const CStatusMessage msg =
  	CLogMessage(this).warning(u"Loading for '%1' already in progress, will NOT load.")
  	<< simulator.toQString();
  	this->showOverlayMessage(msg);
  	return;
  	}
  	else
  	{
  	const CStatusMessage msg =
  	CLogMessage(this).warning(
  	u"Loading for another simulator '%1' already in progress. Loading might be slow.")
  	<< simulator.toQString();
  	this->showOverlayMessage(msg);
  	}
  	}
  	if (!this->initModelLoader(simulator))
  	{
  	const CStatusMessage msg = CLogMessage(this).error(u"Cannot init model loader for %1")
  	<< simulator.toQString();
  	this->showOverlayMessage(msg);
  	return;
  	}
  	// Do not check for empty models die here, as depending on mode we could still load
  	// will be checked in model loader
  	CLogMessage(this).info(u"Starting loading for '%1' in mode '%2'")
  	<< simulator.toQString() << IAircraftModelLoader::enumToString(mode);
  	ui->tvp_OwnAircraftModels->showLoadIndicator();
  	Q_ASSERT_X(sGui && sGui->getWebDataServices(), Q_FUNC_INFO, "missing web data services");
  	m_modelLoader->startLoading(
  	mode, static_cast<int (*)(CAircraftModelList &, bool)>(&CDatabaseUtils::consolidateModelsWithDbData),
  	modelDirectories);