Make {Trace|Span}ID conform to Collection

[t089]

And remove bytes.

Alternative to #18

Avoids a bunch of code and should yield the same results and be even easier to use. Still need to run the benchmark.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.54%. Comparing base (aeeea07) to head (92a46a0).

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   99.50%   99.54%   +0.04%     
==========================================
  Files           6        6              
  Lines         402      442      +40     
==========================================
+ Hits          400      440      +40     
  Misses          2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[slashmo]

LGTM 👍 I agree that this feels even better than the previous approach. Could you please run the soundness script on the PR? Then it should work on CI as well.

[t089]

I am still not sure if we really want {Trace|Span}ID to be a Collection<UInt8> itself or should the ID value be more opaque. If they would not be a collection themself, it would still be possible to expose a public var bytes: some Collection<UInt8> which exposes the underlying tuple as a Collection<UInt8> struct wrapper. This would then again be more similar to the previous PR #18.

[slashmo]

it would still be possible to expose a public var bytes: some Collection which exposes the underlying tuple as a Collection struct wrapper

Wouldn't this cause an allocation when accessing the bytes by creating an instance of the struct wrapper?

[t089]

I think I found a way to make #18 nicer

[slashmo]

Cool! Please ping me on the other PR once there's something new to review 🙏