Improves Swift available attribute generation based on OTel deprecation metadata
#19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This decodes the different OTel deprecation type options, and renders different Swift deprecation attributes based on that type
slashmo
previously approved these changes
May 25, 2025
slashmo
reviewed
May 25, 2025
This adjusts the rename_to deprecation logic to correctly resolve Swift member names, while allowing different rendering type hierarchies, and namespace/property naming strategies. It does so by introducing an `attributeIdToSwiftMemberPath` requirement on the FileRenderer protocol, and using that protocol in the deprecation logic. Since this function typically requires walking the full namespace tree, a Context type was added to inject the namespace tree into the renderers for reference. Finally, the deprecation tests now require a fake namespace tree for renamed deprecation type resolution. There were no changes to the current generated code-set resulting from these adjustments.
NeedleInAJayStack
force-pushed
the
feat/deprecation-attributes
branch
from
79a8b7e to
0dd164c
Compare
slashmo
approved these changes
May 26, 2025
slashmo
requested changes
May 26, 2025
Thanks! Yeah, it'll be cool to have it be really smooth and usable. Thanks for the review! |
slashmo
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decodes the different OTel deprecation type options, and renders different Swift
@availableattributes based on that type. Specifically,renamedattributes get arenamedargument in the Swift attribute, andobsoletedget a prefix to theirmessage. Non-labeled OTel deprecations are interpreted asuncategorized, which are translated to an ordinary Swift deprecation without arenamedsection ormessageprefix.It introduces tests to the Generator package, covering these particular decoding and generation paths.
This resolves #15