Skip to content

Rename getPeerID() #14

@btoms20

Description

@btoms20

What:

  • Rename the following function
Multiaddr.getPeerID() -> String

Why:

  • The current implementation doesn't return a PeerID but a string rep of the ID instead
  • Due to PeerID (swift-peer-id) not being a dependency of Multiaddr (swift-multiaddr) we can't return an actual PeerID

Proposed Change:

  • Rename to
Multiaddr.getPeerIDString() -> String
// either
Multiaddr.getPeerID() -> PeerID?
// or
Multiaddr.getPeerID() throws -> PeerID

Metadata

Metadata

Assignees

Labels

breaking-changeRequires a breaking change in the API

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions