-
Notifications
You must be signed in to change notification settings - Fork 2
Labels
breaking-changeRequires a breaking change in the APIRequires a breaking change in the API
Description
What:
- Rename the following function
Multiaddr.getPeerID() -> StringWhy:
- The current implementation doesn't return a PeerID but a string rep of the ID instead
- Due to
PeerID(swift-peer-id) not being a dependency ofMultiaddr(swift-multiaddr) we can't return an actualPeerID
Proposed Change:
- Rename to
Multiaddr.getPeerIDString() -> String- Then in swift-libp2p-core, we can extend
Multiaddrwith a proper method
// either
Multiaddr.getPeerID() -> PeerID?
// or
Multiaddr.getPeerID() throws -> PeerIDMetadata
Metadata
Assignees
Labels
breaking-changeRequires a breaking change in the APIRequires a breaking change in the API