Skip to content

Fixes #22 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JBosecker
Copy link
Contributor

This pull request fixes issue #22.

@codecov
Copy link

codecov bot commented Jan 10, 2021

Codecov Report

Merging #23 (b499376) into main (bf6706e) will increase coverage by 1.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   90.05%   91.22%   +1.16%     
==========================================
  Files           2        2              
  Lines         171      171              
==========================================
+ Hits          154      156       +2     
+ Misses         17       15       -2     
Impacted Files Coverage Δ
Sources/ExtrasBase64/Chromium.swift 92.77% <100.00%> (+1.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf6706e...b499376. Read the comment docs.

Copy link
Member

@slashmo slashmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks you @JBosecker for fixing this issue, and thanks to @patrickfreed for reporting it!

@slashmo slashmo merged commit 778e00d into swift-extras:main Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants