Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: term definition for Hashtag type #8

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Fix: term definition for Hashtag type #8

merged 1 commit into from
Apr 22, 2024

Conversation

trwnh
Copy link
Contributor

@trwnh trwnh commented Apr 22, 2024

types/classes are conventionally defined first, before property definitions. also, Hashtag is not a property that points to a graph node, nor is it a property at all, so the usage of @type: @id was inappropriate.

types/classes are conventionally defined first, before property definitions. also, Hashtag is not a property that points to a graph node, nor is it a property at all, so the usage of `@type: @id` was inappropriate.
Copy link
Collaborator

@evanp evanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@evanp evanp merged commit 91c7e2a into swicg:main Apr 22, 2024
@trwnh trwnh deleted the patch-1 branch April 22, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants