fix: respect fractional line height in previews#37
Open
hazre wants to merge 2 commits intosweepai:mainfrom
Open
fix: respect fractional line height in previews#37hazre wants to merge 2 commits intosweepai:mainfrom
hazre wants to merge 2 commits intosweepai:mainfrom
Conversation
Collaborator
|
@hazre can you add some screenshots showing this & thanks for opening a PR, apologies for any bugs we're still in early beta |
Author
|
Yeah sure, not exactly 1:1 (but this is what I have right now) Before: After: |
Author
|
Maybe it's related to my theme? I'm using https://marketplace.visualstudio.com/items?itemName=antfu.theme-vitesse |
Collaborator
|
I've gotten a few reports of some themes rendering very very oddly that I need to figure out as I haven't been able to replicate it with my themes or swapping themes myself 
|
Collaborator
|
@hazre quick question what OS are you using? |
Author
|
Windows 11, also idk if this is relevant but I'm using the "CaskaydiaCove Nerd Font" font in vscode |
Collaborator
|
starting to think there's an issue with theme & font loading on windows as I can't recreate the font problems on macOS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the tiny next‑edit preview by properly handling fractional line heights and centralizing preview box sizing so the inline diff renders at readable height across themes and fonts.