fix: use amin/amax from numpy #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
zkamvar
pushed a commit
that referenced
this pull request
Apr 21, 2023
fix: use amin/amax from numpy Hi @henryiii , Thank you for the pull request. Since numpy.min and numpy.max don't actually exist on the official documentation so it would also make sense to change them to numpy.amin and numpy.amax in the lesson.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NumPy provides
aminandamax(array min, array max), you should not useminandmaxin new code. The problem is thatfrom numpy import *causesminandmaxto be replaced by these NumPy versions. Some highlighters also don't likenumpy.minand highlight theminas if it's a builtin. Finally, the NumPy docs forminjust point atamin(andamindocs don't even include min in the see also). And only amin/amax show up in the sidebar.