Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Episode 8, functions : about reading a global variable inside a function #942

Merged
merged 6 commits into from
Jul 14, 2021

Conversation

chavid
Copy link
Contributor

@chavid chavid commented Jul 5, 2021

Reading a global variable inside a function As discussed in #934, this is a proposal to say a few words abour reading a global variable inside a function, because this is used later on in a challenge of this episode, and finally listed in the key points.

Copy link
Contributor

@ldko ldko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up from the issue @chavid ! The review includes my suggestions.

reference.md Show resolved Hide resolved
_episodes/08-func.md Outdated Show resolved Hide resolved
_episodes/08-func.md Outdated Show resolved Hide resolved
_episodes/08-func.md Outdated Show resolved Hide resolved
@chavid
Copy link
Contributor Author

chavid commented Jul 12, 2021

New proposal to be reviewed.

Copy link
Contributor

@ldko ldko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes look good! Do you have any further comments @maxim-belkin ?

_episodes/08-func.md Outdated Show resolved Hide resolved
_episodes/08-func.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ldko ldko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thank you very much for contributing @chavid ! 👍

@ldko ldko merged commit 11643f1 into swcarpentry:gh-pages Jul 14, 2021
@chavid
Copy link
Contributor Author

chavid commented Jul 15, 2021

Thanks for the reviews and advices :)

zkamvar pushed a commit that referenced this pull request Apr 21, 2023
…ion (#942)

* First proposal

* Remove the global trap explanation from the section about variable scope, and add a sentence in the dedicated challenge.

* Remove dummy sentence extract.

* Move the debate about the local/global trap in the challenge.

* Second review

* Wrap line to keep under 100 characters

Co-authored-by: Lauren Ko <lauren.ko@unt.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants