-
-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Episode 8, functions : about reading a global variable inside a function #942
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for following up from the issue @chavid ! The review includes my suggestions.
…ope, and add a sentence in the dedicated challenge.
New proposal to be reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these changes look good! Do you have any further comments @maxim-belkin ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Thank you very much for contributing @chavid ! 👍
Thanks for the reviews and advices :) |
…ion (#942) * First proposal * Remove the global trap explanation from the section about variable scope, and add a sentence in the dedicated challenge. * Remove dummy sentence extract. * Move the debate about the local/global trap in the challenge. * Second review * Wrap line to keep under 100 characters Co-authored-by: Lauren Ko <lauren.ko@unt.edu>
Reading a global variable inside a function
As discussed in #934, this is a proposal to say a few words abour reading a global variable inside a function, because this is used later on in a challenge of this episode, and finally listed in the key points.