Swapping the order of episodes on lists and loops #926
Conversation
It has been decided (#453) that it is better to describe Python lists before loops. This is the first commit that simply renames the episodes to achieve the desired order. Further work is necessary to ensure that concepts from the episode on loops are not used in the episode on lists.
Pull Request: #626
Pull Request: #567
Pull Request: #634
Co-authored-by: Lauren Ko <lauren.ko@unt.edu>
Co-authored-by: Lauren Ko <lauren.ko@unt.edu>
|
Thank you, Lauren. All good suggestions/edits. |
There was a problem hiding this comment.
This looks good to me. I see the there is a build failure, but it doesn't look specifically relevant to the changes here. make lesson-check-all outputs what I would expect locally.
Thanks very much for wrapping this up @maxim-belkin ! I imagine a lot of people will be glad to have this change in the lesson. Thanks to everyone who worked on it!
There was a problem hiding this comment.
This is excellent! I also don't know why build fails: it works well for me locally.
I am really looking forward to be teaching this "new" lesson!!! thanks @maxim-belkin
|
The build fails because of the missing python-novice-inflammation/.travis.yml Line 10 in 4f31efa but that's not critical because the main test -- GitHub Action "Website" -- passes. As we discussed previously, we need to announce this change. Do you think we should do it before or after merging this PR? |
On the issue you mention announcing it on the Carpentries' Discuss channel. I am not sure what that refers to :D. Will a lot of people see it there? It does make sense to give notice though, in particular because of the accounts mentioned in this recent RFC. It seems to me not waiting too long to merge it though would be good, so we don't lose hold of it again. Does it also make sense to do a tag/release for the version before we merge the change? |
|
It is a good idea to do a tag/release for the version before merging. For announcing it: I am not sure what is best but announcing it in the Carpentries' Discuss channel seems a good idea (I guess many people will be reached). |
My understanding is that lesson releases are coordinated across The Carpentries org(s) and are performed by The Carpentries' staff. @fmichonneau, what are our options here? |
I was talking about https://carpentries.topicbox.com/ . For example, this is our previous Request (Call) for Contributions: https://carpentries.topicbox.com/groups/discuss/Tb9e8878a4c4c4fa8-M281b5e6b472544bacf432926/call-for-contributions-visuals-images-figures-plots-charts-etc |
maxim-belkin
changed the title
Swapping the order of episodes on lists and loops
See #496 for more info.