Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix long lines in README.md #911

Merged
merged 2 commits into from
Mar 4, 2021

Conversation

gmingas
Copy link
Contributor

@gmingas gmingas commented Feb 28, 2021

Fixes long lines in README.md.

Partially addresses #498.

Copy link
Contributor

@ldko ldko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gmingas ,
Thanks for putting together pull requests to fix the long lines in this lesson. Looking at the rendered version of the README.md with your changes, it looks like breaking up the lines that make up the table in the Github markdown causes the separated out text to appear on separate rows. I'm not sure if there is a way to get those lines under 100 characters without this happening (if anyone knows how, please let us know), so we may need to leave those lines longer than the general preference to have it render correctly.

Copy link
Contributor

@maxim-belkin maxim-belkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Thanks again, @gmingas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants