Fix 'Computing the Value of a Polynomial' exercise #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Output block in this exercise contains two assignments to the variable y, which neither looks like an Output nor does it follow from the preceding Python block when run. I believe the first assignment to y was intended to be part of the Python block, and I also believe the intent was to print the value of y, which is 97, instead of assigning 97 to it in the Output block. This commit does the following: - moves the first y assignment from the Output block into the Python block - adds a print(y) statement to the end of the Python block - removes the assignment from the y = 97 line, so that the Output block matches the output of the edited Python block when it is run.
|
Thanks, @marijane. I think the change makes sense and this typo dates back to 2016 (bb8857f) when this exercise was first added to the lesson. @annefou and @ldko: I think this piece misses a few words about cubic polynomial (e.g. "here is how we can compute a cubic polynomial" or something along these lines) -- what do you think? |
annefou
approved these changes
Nov 18, 2019
zkamvar
pushed a commit
that referenced
this pull request
Apr 21, 2023
The Output block in this exercise contains two assignments to the variable `y`, which neither looks like an Output nor does it follow from the preceding Python block when run. I believe the first assignment to `y` was intended to be part of the Python block, and I also believe the intent was to print the value of `y`, which is 97, instead of assigning 97 to it in the Output block. This commit does the following: - moves the first `y` assignment from the Output block into the Python block - adds a `print(y)` statement to the end of the Python block - removes the assignment from the `y = 97` line, so that the Output block matches the output of the edited Python block when it is run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Output block in this exercise contains two assignments to the variable y, which neither looks like an Output nor does it follow from the preceding Python block when run.
I believe the first assignment to y was intended to be part of the Python block, and I also believe the intent was to print the value of y, which is 97, instead of assigning 97 to it in the Output block.
This commit does the following: