Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 08-defensive.md: exercise time #705

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

davidbenncsiro
Copy link
Contributor

The time required for exercises in this episode is I think between 5 and 10 minutes. Of course, times required for all episodes' exercises really depends upon the experience of participants. I'm sure I'm not saying anything you don't know. :)

The time required for exercises in this episode is I think between 5 and 10 minutes. Of course, times required for all episodes' exercises really depends upon the experience of participants. I'm sure I'm not saying anything you don't know. :)
@davidbenncsiro davidbenncsiro changed the title Update 08-defensive.md Update 08-defensive.md: exercise time Aug 26, 2019
@maxim-belkin
Copy link
Contributor

For three exercises 10 minutes is not realistic. However, I'm tempted to remove the last exercise because:
a) its wording is not clear: "Fix" may have many different things
b) we haven't introduced min and max functions (which we might have to "fix")

Therefore, I suggest we:

  1. Merge this PR
  2. Move the last exercise to _extras/extra_exercises.md

After that, we should discuss how we can introduce min and max functions.

@maxim-belkin maxim-belkin added the type:enhancement Propose enhancement to the lesson label Sep 10, 2019
@maxim-belkin maxim-belkin merged commit 9446c97 into swcarpentry:gh-pages Sep 10, 2019
@maxim-belkin
Copy link
Contributor

Thank you, David!

@davidbenncsiro
Copy link
Contributor Author

@maxim-belkin, thanks. Do we need to open a new issue for your idea above of moving the last exercise to _extras/extra_exercises.md and discussion of how we can introduce min and max functions?

@davidbenncsiro davidbenncsiro deleted the patch-14 branch September 15, 2019 05:13
@maxim-belkin
Copy link
Contributor

I moved that exercise to "extras" in dc112ff.
We need to discuss the second part of the suggestion in a separate issue (or a PR, if you've got some ideas already).

dkelsey88 added a commit to dkelsey88/python-novice-inflammation that referenced this pull request Mar 12, 2021
Improve content accessibility by expanding word contractions swcarpentry#705
@dkelsey88 dkelsey88 mentioned this pull request Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Propose enhancement to the lesson
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants