Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up figure python-call-stack-07.svg #658

Merged
merged 2 commits into from
Jun 13, 2019
Merged

Cleaned up figure python-call-stack-07.svg #658

merged 2 commits into from
Jun 13, 2019

Conversation

ssvassiliev
Copy link
Contributor

Addressing issue #494 I have cleaned up the file "python-call-stack-07.svg" to make it easily maintainable. The new file has 36 lines of code including comments. If you approve changes I can work on the other images.

@maxim-belkin
Copy link
Contributor

Wow! It looks fantastic! The only comment I have is that you set width and height to very high values (2500 and 1500) and as a result the image is not being displayed properly on the rendered HTML page. It would be great if you could set width and height to the actual width and height. I believe you can use 705 for width and 375 for height.

@ssvassiliev
Copy link
Contributor Author

Right, no problem I'll fix it

Copy link
Contributor

@maxim-belkin maxim-belkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, Sergey!

@maxim-belkin maxim-belkin merged commit a23437e into swcarpentry:gh-pages Jun 13, 2019
@ssvassiliev ssvassiliev deleted the figures-cleanup branch June 14, 2019 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants