Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

01-numpy.md: simplify wording #592

Merged
merged 2 commits into from
Oct 23, 2018
Merged

01-numpy.md: simplify wording #592

merged 2 commits into from
Oct 23, 2018

Conversation

maxim-belkin
Copy link
Contributor

  1. automatically seems to be unnecessary as the main point is that weight_lb is not updated.
  2. languages like seems to be not necessary either as at this point learners know that we're talking about Python and no need to generalize.
  3. Removed two extra blank lines...

@maxim-belkin maxim-belkin added the type:clarification Suggest change for make lesson clearer label Oct 22, 2018
@maxim-belkin maxim-belkin self-assigned this Oct 22, 2018
annefou
annefou approved these changes Oct 23, 2018
View reviewed changes
Copy link

@annefou annefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you, especially replacing "language like" by python.

I have no opinion on removing "automatically" but removing all the non fundamtental words is a very good approach.

Thanks.

@maxim-belkin
Copy link
Contributor Author

Thanks, Anne! Fun fact: I was, actually, more certain about removing automatically than about the other change...

@maxim-belkin maxim-belkin merged commit 57142dd into swcarpentry:gh-pages Oct 23, 2018
@maxim-belkin maxim-belkin deleted the simpler-wording branch October 23, 2018 19:19
zkamvar pushed a commit that referenced this pull request Apr 21, 2023
@maxim-belkin
01-numpy.md: simplify wording
bbdbdff 
Pull Request: #592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annefou annefou annefou approved these changes

Assignees

@maxim-belkin maxim-belkin

Labels
type:clarification Suggest change for make lesson clearer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxim-belkin @annefou