-
-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fig/README.md: add notes about cleaning up SVG files #555
Conversation
b039f08
to
6cbb9de
Compare
Maybe we should mention that these instructions are valid for Linux and Mac-OSX? Do we need to add some information on which tools need to be installed to manipulate SVG files? |
Good points. I will mention that these are Linux/Mac instructions. I'm still not sure if we want to have these instructions here or somewhere in a wiki for maintainers... What do you think? I'm afraid contributors might feel overwhelmed with the amount of instructions we have :). Perhaps, we should just say:
|
I like the idea to give some information on how the SVG files were created; it helps to show that we welcome contributions with new or updated SVG files. And of course, anyone is welcome to use any other tools. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Thanks for approving this, @annefou! I will make minor updates to the instructions for the tools a bit later. |
4753644
to
90848ea
Compare
Consider using only one tool. See instructions here: #573 (comment) |
2f18cdc
to
4044493
Compare
4044493
to
efdebbf
Compare
Follow-up to swcarpentry#555, to make some points clearer or shorter. Open to discussion!
Thanks for these tips! I propose some slight rephrasing in #623. |
Adding notes about cleaning up SVG files.