Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fig/README.md: add notes about cleaning up SVG files #555

Merged
merged 2 commits into from
Feb 17, 2019

Conversation

maxim-belkin
Copy link
Contributor

Adding notes about cleaning up SVG files.

@annefou
Copy link

annefou commented Jun 22, 2018

Maybe we should mention that these instructions are valid for Linux and Mac-OSX? Do we need to add some information on which tools need to be installed to manipulate SVG files?

@maxim-belkin
Copy link
Contributor Author

Good points. I will mention that these are Linux/Mac instructions.

I'm still not sure if we want to have these instructions here or somewhere in a wiki for maintainers... What do you think? I'm afraid contributors might feel overwhelmed with the amount of instructions we have :). Perhaps, we should just say:

use any tool of your choice to create SVG images. When submitting PNG images, please provide exact instructions how these images were obtained.

@annefou
Copy link

annefou commented Jun 22, 2018

I like the idea to give some information on how the SVG files were created; it helps to show that we welcome contributions with new or updated SVG files. And of course, anyone is welcome to use any other tools.
If we don't add it in the README file, should we add it in CONTRIBUTING.md?

Copy link

@annefou annefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@maxim-belkin
Copy link
Contributor Author

Thanks for approving this, @annefou! I will make minor updates to the instructions for the tools a bit later.

@maxim-belkin
Copy link
Contributor Author

Consider using only one tool. See instructions here: #573 (comment)

@maxim-belkin maxim-belkin force-pushed the figs-readme branch 2 times, most recently from 2f18cdc to 4044493 Compare February 17, 2019 07:35
@maxim-belkin maxim-belkin merged commit 5f3421d into swcarpentry:gh-pages Feb 17, 2019
@maxim-belkin maxim-belkin deleted the figs-readme branch February 17, 2019 07:47
slel added a commit to slel/python-novice-inflammation that referenced this pull request Feb 17, 2019
Follow-up to swcarpentry#555, to make some points clearer or shorter. Open to discussion!
@slel slel mentioned this pull request Feb 17, 2019
@slel
Copy link
Contributor

slel commented Feb 17, 2019

Thanks for these tips! I propose some slight rephrasing in #623.

zkamvar pushed a commit that referenced this pull request Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants