Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dictionary references from 09-errors.md #1005

Merged

Conversation

patrick-austin
Copy link
Contributor

Based on the feedback on #809, rather than introducing the concept of a dict have instead modified the exercise to use a list and an IndexError. The solution to the exercise has been modified to reflect this, and have changed print_friday_message to print_sunday_message to make the mistake of providing 7 as the index more plausible.

The original issue also made points about moving the exercise earlier. Given this wasn't addressed in the PR comments I assume that this is fine.

closes #783

@knarrff
Copy link
Contributor

knarrff commented Mar 3, 2023

I stumbled over the same issue in my own course yesterday and just came here with the intent of opening a very similar pull request myself only to find that there is already one open (thanks @patrick-austin). It would be nice to get this merged or some reaction from a maintainer? I does not create an inclusive feeling to leave pull requests open for so long without any reaction.

@noatgnu noatgnu merged commit e6c1c87 into swcarpentry:gh-pages Mar 21, 2023
@zkamvar
Copy link
Contributor

zkamvar commented Mar 21, 2023

It would be nice to get this merged or some reaction from a maintainer? I does not create an inclusive feeling to leave pull requests open for so long without any reaction.

Hello @knarrff,

I am a member of @swcarpentry/staff-curriculum and I hope I can provide some context: the maintainers for these lessons are working on a volunteer basis and the current maintainers inherited a very large backlog of pull requests last year. They are indeed trying to get through as many pull requests as they can while keeping the lesson up-to-date. The maintainer community has only recently organised and we on the core team are working as hard as we can to support them. If you have any questions or concerns, feel free to email us at curriculum@carpentries.org.

All the best,
Zhian

zkamvar pushed a commit that referenced this pull request Apr 21, 2023
…-errors

Remove dictionary references from 09-errors.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dictionaries not introduced but used in exercise in "Error and Exceptions" - & suggestiong
4 participants